Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: partly revert pr/35975, do it correctly this time (#55196) #56009

Merged
merged 4 commits into from
Nov 6, 2024
Merged

store/copr: partly revert pr/35975, do it correctly this time (#55196) #56009

merged 4 commits into from
Nov 6, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55196

What problem does this PR solve?

Issue Number: close #54969

Problem Summary:

What changed and how does it work?

#55155 try to revert pr/35975 but not clean, coupling with #41500 and bring bugs. PartitionNum is 1 even on non-partitioned table.

Do it correctly in this PR.
The new behaviour now:

  • The 'select ... where ... order by ...' query will not reduce distsql concurrency to 2 (change)
  • The simple 'select ... limit N' query, when N < 10000 , distsql concurrency is set to 1 (keep the behavior no change)
    • The same 'select ... limit N' query, on partitioned table, distsql concurrency is set to partition number (keep the behavior no change)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 11, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 11, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 6, 2024
@tiancaiamao tiancaiamao mentioned this pull request Nov 6, 2024
Closed
13 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1@aad5075). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.1     #56009   +/-   ##
================================================
  Coverage               ?   73.4593%           
================================================
  Files                  ?       1212           
  Lines                  ?     380873           
  Branches               ?          0           
================================================
  Hits                   ?     279787           
  Misses                 ?      83219           
  Partials               ?      17867

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 07:30:26.467905151 +0000 UTC m=+1026139.307060696: ☑️ agreed by Defined2014.
  • 2024-11-06 08:16:28.692639257 +0000 UTC m=+1028901.531794796: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit 691fde0 into pingcap:release-7.1 Nov 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees

@tiancaiamao tiancaiamao

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @tiancaiamao @Defined2014